#25939: Remove transaction from QuerySet.update_or_create's save()
-------------------------------------+-------------------------------------
Reporter: timgraham | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"423b3afce431fd0a1d683bca9b2b80a1c4e3c8ca" 423b3afc]:
{{{
#!CommitTicketReference repository=""
revision="423b3afce431fd0a1d683bca9b2b80a1c4e3c8ca"
Fixed #25939 -- Removed redundant transaction in
QuerySet.update_or_create().
There is no need to wrap the save() call in transaction.atomic() as
it's already done down the call stack in Model.save_base().
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25939#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.d5f6d6fb387bbd999b76613a1a1f699e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
