#25165: Move JavaScript calls out of HTML to fix JavaScript "no-script-eval" warnings -------------------------------------+------------------------------------- Reporter: timgraham | Owner: Tim Type: | Graham <timograham@…> Cleanup/optimization | Status: new Component: contrib.admin | Version: master Severity: Release blocker | Resolution: Keywords: | Triage Stage: Accepted Has patch: 0 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 0 Easy pickings: 0 | UI/UX: 0 -------------------------------------+------------------------------------- Changes (by timgraham):
* status: closed => new * has_patch: 1 => 0 * resolution: fixed => * severity: Normal => Release blocker Comment: Hi Thomas, I noticed a regression due to this change. Go to the admin change form of an object with a foreign key and use the "Add another" button on the foreign key field. After creating a new object using the popup, the popup doesn't close and the JavaScript console displays `TypeError: text.replace is not a function`. Are you able to investigate? -- Ticket URL: <https://code.djangoproject.com/ticket/25165#comment:4> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To post to this group, send email to django-updates@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.8f6cde42872e5ddab35e31492955c6af%40djangoproject.com. For more options, visit https://groups.google.com/d/optout.