#26024: ConditionalGetMiddleware's ETag is broken
-------------------------------------+-------------------------------------
Reporter: samifahed | Owner: samifahed
Type: Bug | Status: new
Component: Core (Cache system) | Version: 1.9
Severity: Normal | Resolution:
Keywords: Etags | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by samifahed):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Old description:
> ETag support is broken in ConditionalGetMiddleware
>
> django.utils.cache.get_conditional_response's etag argument needs to be
> *unquoted*, however the etag passed by CommonMiddleware's make_response
> is quoted or the GZipMiddleware is modifying it while keeping it quoted.
New description:
ETag support is broken in ConditionalGetMiddleware
django.utils.cache.get_conditional_response's etag argument needs to be
*unquoted*, however the etag passed by CommonMiddleware's make_response is
quoted or the GZipMiddleware is modifying it while keeping it quoted.
Pull request with Regression Test:
https://github.com/django/django/pull/5919
--
--
Ticket URL: <https://code.djangoproject.com/ticket/26024#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.07e43a07231f93c3d4d7f07521fffc28%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
