#25878: APPEND_SLASH doesn't work with DEBUG=False when template/404.html is
erroneous
---------------------------------+-------------------------------------
Reporter: kuna | Owner: timgraham
Type: Bug | Status: assigned
Component: HTTP handling | Version: 1.9
Severity: Release blocker | Resolution:
Keywords: slash,debug | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+-------------------------------------
Comment (by pulsedemon):
Replying to [comment:21 timgraham]:
> Right, so with 434d309ef6dbecbfd2b322d3a1da78aa5cb05fa8 (#24720) your
`handler404` (which is only used when `DEBUG=False`, must return a 404
status code, otherwise `APPEND_SLASH` won't work correctly. I don't think
this is an unreasonable requirement, but it needs to be mentioned in the
1.9 release notes as a backwards-incompatible change (unless someone
thinks this needs to go through a deprecation path and thus we should
revert the original patch on 1.9). We could add logging as I mentioned in
comment 19 to help developers find this mistake in their handler.
I think a warning and comment about this in the release
notes/documentation is good enough personally. It's not unreasonable to
expect the status_code be set manually when implementing a custom handler.
--
Ticket URL: <https://code.djangoproject.com/ticket/25878#comment:23>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/062.fca1a2c8b954a8aeeaf86d367b29716f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
