#26038: FileSystemStorage size() method does not use current MEDIA_ROOT setting
value
--------------------------------------+------------------------------------
     Reporter:  voutilad              |                    Owner:  nobody
         Type:  Bug                   |                   Status:  new
    Component:  File uploads/storage  |                  Version:  master
     Severity:  Normal                |               Resolution:
     Keywords:  testing fieldfile     |             Triage Stage:  Accepted
    Has patch:  0                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by charettes):

 * version:  1.8 => master
 * stage:  Unreviewed => Accepted


Comment:

 I think `django.core.files.storage.FileSystemStorage` should take care of
 recomputing its settings based properties (`MEDIAL_URL`, `MEDIA_ROOT`,
 `FILE_UPLOAD_PERMISSIONS` and `FILE_UPLOAD_DIRECTORY_PERMISSIONS`) by
 itself by registering a weak `setting_changed` receiver during its
 initialization phase.

 The `default_storage` should only be reset if `DEFAULT_FILE_STORAGE` is
 changed.

--
Ticket URL: <https://code.djangoproject.com/ticket/26038#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.8f814b3726e76dba1b458db703cdeb02%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to