#26048: Switch selenium tests to use implicitly_wait() instead of custom wait
functions.
--------------------------------------+------------------------------------
Reporter: timgraham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Description changed by timgraham:
Old description:
> From the selenium docs, "Dependent on several factors, including the
> OS/Browser combination, WebDriver may or may not wait for the page to
> load. In some circumstances, WebDriver may return control before the page
> has finished, or even started, loading. To ensure robustness, you need to
> wait for the element(s) to exist in the page using Explicit and Implicit
> Waits."
>
> Currently, we have a collection of
> [https://github.com/django/django/blob/7f7553dd30534d606c84952a3f6dcb64b396ce37/django/contrib/admin/tests.py#L49-L120
> wait_for*] methods to accomplish this. The idea is to switch our code to
> call `self.selenium.implicitly_wait(10)` after initializing
> `self.selenium` which should allow us to remove many of these waiting
> calls.
New description:
From the selenium docs, "Dependent on several factors, including the
OS/Browser combination, WebDriver may or may not wait for the page to
load. In some circumstances, WebDriver may return control before the page
has finished, or even started, loading. To ensure robustness, you need to
wait for the element(s) to exist in the page using
[http://docs.seleniumhq.org/docs/04_webdriver_advanced.jsp#explicit-and-
implicit-waits-reference Explicit and Implicit Waits]."
Currently, we have a collection of
[https://github.com/django/django/blob/7f7553dd30534d606c84952a3f6dcb64b396ce37/django/contrib/admin/tests.py#L49-L120
wait_for*] methods to accomplish this. The idea is to switch our code to
call `self.selenium.implicitly_wait(10)` after initializing
`self.selenium` which should allow us to remove many of these waiting
calls.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/26048#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.12556bdfe0bf1baeab03274d2af5f1d1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
