#4976: The contrib.humanize templatetags fail when given None.
-------------------------+--------------------------------------------------
Reporter: anonymous | Owner: adrian
Status: new | Component: Contrib apps
Version: SVN | Resolution:
Keywords: | Stage: Design decision needed
Has_patch: 1 | Needs_docs: 0
Needs_tests: 0 | Needs_better_patch: 0
-------------------------+--------------------------------------------------
Changes (by Simon G. <[EMAIL PROTECTED]>):
* needs_better_patch: => 0
* stage: Unreviewed => Design decision needed
* summary: The ordinal (contrib.humanize) templatetag fails when passing
in None => The contrib.humanize templatetags
fail when given None.
* needs_tests: => 0
* needs_docs: => 0
Comment:
Thanks for pointing this out.
The tests for humanize are in django/tests/regressiontests/humanize, but
it looks like all the others in there will choke on None too. Whilst
people probably shouldn't be passing invalid input to these, I've expanded
your patch to cover these cases (and tests), and will let one of the core
developers decide whether this is the right approach.
--
Ticket URL: <http://code.djangoproject.com/ticket/4976#comment:1>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
