#24974: Cannot create subclass of form created by `modelform_factory()`, e.g. in
`ModelAdmin.get_form()`
-------------------------------------+-------------------------------------
Reporter: mrmachine | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 1.8
Severity: Normal | Resolution:
Keywords: form modelform | Triage Stage: Accepted
modelform_factory modeladmin |
get_site metaclass |
modelformmetaclass |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by tolomea):
As another example we're doing this in our common ModelAdmin extension:
{{{
def get_form(self, request, obj=None, **kwargs):
field_overrides = self.get_field_overrides()
readonly_fields = set(self.get_readonly_fields(request, obj))
fields = {name: field for name, field in
field_overrides.iteritems() if name not in readonly_fields}
form = type(self.form)(self.form.__name__ + b"_", (self.form,),
fields)
return super(YPModelAdmin, self).get_form(request, obj, form=form,
**kwargs)
}}}
I ended up here because the more natural approach would be:
{{{
def get_form(self, request, obj=None, **kwargs):
form = super(YPModelAdmin, self).get_form(request, obj, **kwargs)
field_overrides = self.get_field_overrides()
readonly_fields = set(self.get_readonly_fields(request, obj))
fields = {name: field for name, field in
field_overrides.iteritems() if name not in readonly_fields}
return type(form)(form.__name__ + b"_", (form,), fields)
}}}
But that doesn't work right due to this issue.
--
Ticket URL: <https://code.djangoproject.com/ticket/24974#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.40c8c3e57529b23122830a239f769634%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
