#23971: Allow list filter filtering of None on null date fields
-------------------------------------+-------------------------------------
Reporter: rynomster | Owner: rynomster
Type: New feature | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: filter, admin | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by rynomster):
Replying to [comment:11 Tim Graham <timograham@…>]:
> In [changeset:"468d8211df999845607c3bb163c859e428d39dea" 468d8211]:
> {{{
> #!CommitTicketReference repository=""
revision="468d8211df999845607c3bb163c859e428d39dea"
> Fixed #23971 -- Added "Has date"/"No date" choices for
DateFieldListFilter.
> }}}
I just thought I'd bring up a previous comment, about clearer distinction:
Replying to [comment:5 timgraham]:
> This seems okay, although it might make the UI a bit confusing because
the distinction between 'Any date' and 'Has date' isn't so clear.
>
> The patch can be cleaned up a bit if you work through our
[https://docs.djangoproject.com/en/dev/internals/contributing/writing-code
/submitting-patches/#patch-review-checklist patch review checklist].
That's the main reason I went for Has valid date.
--
Ticket URL: <https://code.djangoproject.com/ticket/23971#comment:12>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.43af275842e6dc1a5da54101ee71128d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
