#23155: Add request attr to user_login_failed signal
------------------------------+------------------------------------
     Reporter:  anonymous     |                    Owner:  nobody
         Type:  New feature   |                   Status:  new
    Component:  contrib.auth  |                  Version:  master
     Severity:  Normal        |               Resolution:
     Keywords:                |             Triage Stage:  Accepted
    Has patch:  1             |      Needs documentation:  0
  Needs tests:  0             |  Patch needs improvement:  1
Easy pickings:  0             |                    UI/UX:  0
------------------------------+------------------------------------

Comment (by timgraham):

 What I meant about a separate ticket for a deprecation to make `request` a
 required argument for authentication backends is something like this in
 `authenticate()`:
 {{{ #!python
 try:
     inspect.getcallargs(backend.authenticate, request, **credentials)
 except TypeError:
     try:
         inspect.getcallargs(backend.authenticate, **credentials)
     except TypeError:
         # This backend doesn't accept these credentials as arguments. Try
 the next one.
         continue
     else:
         warnings.warn(
             "Update authentication backend %s to accept a "
             "positional `request` argument." % backend
             RemovedInDjango20Warning
         )
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/23155#comment:19>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.fb3eeaa3113b967d02198e8f23dbd221%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to