#26440: Add check that all items in url patterns are url instances
-------------------------------------+-------------------------------------
Reporter: alasdairnicol | Owner: burhan
Type: | Status: assigned
Cleanup/optimization |
Component: Core (System | Version: master
checks) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by alasdairnicol):
* needs_better_patch: 0 => 1
Comment:
Sorry for changing the patch after it had been reviewed. I've added a
couple more patches to the pull request
* Added explicit test that URL checks are recursive, and simplified other
url configs
* Added hints when users have a string or tuple instead of a url()
instance
I think the text of the hints could be improved. I'm not 100% sure that
the tuple hint is necessary - maybe saying the main warning 'Ensure that
urlpatterns is a list' is enough.
--
Ticket URL: <https://code.djangoproject.com/ticket/26440#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/071.a91fd9f2d516e272633a47d8059aef6a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
