#26585: Cascade-deletion through generic foreign keys ignores field names
-------------------------------------+-------------------------------------
Reporter: nicklecoder | Owner: nobody
Type: Bug | Status: new
Component: | Version: 1.8
contrib.contenttypes |
Severity: Normal | Resolution:
Keywords: genericforeignkey | Triage Stage:
delete | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by nicklecoder):
* needs_docs: => 0
* needs_tests: => 0
* needs_better_patch: => 0
Old description:
> Create three models:
>
> {{{
> from django.db import models
> from django.contrib.contenttypes import generic
> class Location(models.Model):
> address_line1 = models.CharField()
>
> class Account(models.Model):
> acct_number = models.CharField()
>
> class Link(models.Model):
> account = models.ForeignKey(Account)
> linked_object_id = models.PositiveIntegerField()
> linked_object_content_type = models.ForeignKey(ContentType)
> linked_object =
> generic.GenericForeignKey('linked_object_content_type',
> 'linked_object_id')
> }}}
>
> With this setup, deleting a `Location` object will attempt to cascade-
> delete any associated `Link` objects. In doing so, Django ignores the
> parameters to the `GenericForeignKey` field constructor and instead
> expects the content type to be in a field called `content_type` and the
> object id in `object_id`. This prevents cascade deletion through generic
> foreign keys from working whenever these fields aren't named as expected
> or whenever there are multiple generic foreign keys in a model.
New description:
Create three models:
{{{
from django.db import models
from django.contrib.contenttypes import generic
class Location(models.Model):
address_line1 = models.CharField()
class Account(models.Model):
acct_number = models.CharField()
class Link(models.Model):
account = models.ForeignKey(Account)
linked_object_id = models.PositiveIntegerField()
linked_object_content_type = models.ForeignKey(ContentType)
linked_object =
generic.GenericForeignKey('linked_object_content_type',
'linked_object_id')
}}}
With this setup, deleting a `Location` object will attempt to cascade-
delete any associated `Link` objects. In doing so, Django ignores the
parameters to the `GenericForeignKey` field constructor and instead
expects the content type to be in a field called `content_type` and the
object id in `object_id`. This prevents cascade deletion through generic
foreign keys from working whenever these fields aren't named as expected
or whenever there are multiple generic foreign keys in a model.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/26585#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/069.eb8db9ece66113b1280edd3161a7d057%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
