#24227: isinstance checks on ForeignKey/ManyToManyField should be replaced with
field.many_to_one/field.many_to_many
-------------------------------------+-------------------------------------
     Reporter:  coldmind             |                    Owner:  coldmind
         Type:                       |                   Status:  assigned
  Cleanup/optimization               |
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by timgraham):

 * needs_better_patch:  0 => 1
 * stage:  Ready for checkin => Accepted


Comment:

 Claude abandoned [https://github.com/django/django/pull/6236 the PR] to
 change instances of `isinstance(field, ForeignKey)` to
 `field.many_to_one`. If someone sees an advantage to those changes, feel
 free to send a new PR.

--
Ticket URL: <https://code.djangoproject.com/ticket/24227#comment:21>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4e3d7926aabd31c2c6a6bdb71066bc04%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to