#27035: DiscoverRunner's setup_test_environment() hard-codes settings.DEBUG to
False
-------------------------------------+-------------------------------------
Reporter: cjerdonek | Owner: cjerdonek
Type: | Status: assigned
Cleanup/optimization |
Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by cjerdonek):
This issue is just an easy subset of what would be done for #27008
anyways. But it has the nice feature that it would make it easier for
others to add a `--debug` option on their own via subclassing even before
#27008 is closed.
In other words, I wasn't saying #27008 would be addressed via sub-
classing. Rather, it would allow others to subclass in lieu of the issue.
In terms of your suggestion, adding an argument to
`DiscoverRunner.setup_test_environment()` would just push the issue back
another method to `DiscoverRunner.run_tests()`, where
`setup_test_environment()` is called (in which case subclassers would have
to reimplement all of `run_tests()` just to change how
`setup_test_environment()` is called). All of the other command-line
options work by setting an instance attribute in the constructor and using
those attributes throughout the methods, which is what I'm suggesting
doing here.
--
Ticket URL: <https://code.djangoproject.com/ticket/27035#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.f97e71ee719a52eedc131ffe5fd5e392%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
