#4933: django/core/xheaders.py violates PEP8 and has a typo
---------------------------------------------------------+------------------
Reporter: Ludvig Ericson <[EMAIL PROTECTED]> | Owner:
adrian
Status: new |
Component: Core framework
Version: SVN |
Resolution:
Keywords: |
Stage: Ready for checkin
Has_patch: 1 |
Needs_docs: 0
Needs_tests: 0 |
Needs_better_patch: 0
---------------------------------------------------------+------------------
Comment (by mtredinnick):
We can certainly fix the typo (good catch).
I've reformatted the if test a bit as well to break it over lines.
However, the rest of the rewrite, although well-intentioned, slows down
the code a bit: every time you construct a try-except block, Django has to
save the current stack frame and then free it later For something that is
executed for every single response, we should be a little wary of adding
overhead like that. The existing code gets there without the extra work,
so I prefer that.
--
Ticket URL: <http://code.djangoproject.com/ticket/4933#comment:2>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
