#17208: Dogfood class-based views in contrib.admin
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: yoongkang
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: class-based views | Triage Stage: Accepted
admin |
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by timgraham):
A [https://github.com/django/django/pull/6045 PR] by yoongkang took an
alternate approach but I didn't see if there was a reason to reject the
approach used in earlier versions of the patch that subclassed more
specific class-based views like `UpdateView`, `CreateView`, `DeleteView`?
I have mixed feelings about this conversion in general. I guess it makes
the views easier to customize, but on the other hand, I think it makes the
code more difficult to follow (however I haven't used CBGVs a lot, so it
might just be me).
--
Ticket URL: <https://code.djangoproject.com/ticket/17208#comment:26>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.dcb91767a00218a55fe07502131a4a5d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
