#27234: Clarify the type of the django.server logger's 'request' extra context
-------------------------------------+-------------------------------------
Reporter: Ben Whale | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Documentation | Version: 1.10
Severity: Normal | Resolution:
Keywords: django.request | Triage Stage: Accepted
runserver WSGIRequest socket |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Ben Whale):
I'll leave that judgement to you.
Does #26688 standardise django.request and django.server so that they both
receive WSGIRequests or both receive sockets? This might effect
documentation changes for 1.11.
Because I'm curious, why have both django.request and django.server
loggers? The documentation implies that they do the same thing, after
#26688 they will log the same things and they both run when using
{{{python manage.py runserver}}}. Would it be sensible to look to removing
django.server in favour of django.request at some future point? For
example as an additional patch to 1.11 or even 1.12? If you think it's
worth looking into I'm happy to do some digging to find out what the
changes would look like (I want to learn more about the django internals
in any case).
--
Ticket URL: <https://code.djangoproject.com/ticket/27234#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.65bb4e50b268b8a402c4dd4c25bcf45a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
