#27309: Add CallableBool.__hash__()
-------------------------------------+-------------------------------------
Reporter: Reto Aebersold | Owner: nobody
Type: Bug | Status: new
Component: Utilities | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):
* has_patch: 0 => 1
* stage: Unreviewed => Ready for checkin
Old description:
> As
> [https://github.com/django/django/blob/b7fb608142a0be568bc5dce952de5e6aefc2488c/django/utils/deprecation.py#L87
> CallableBool] has no hash function, membership test operations for sets
> do not work:
>
> {{{
> from django.utils.deprecation import CallableTrue
> assert CallableTrue in {True}
>
> TypeError: unhashable type: 'CallableBool'
> }}}
>
> Adding a hash function solves this problem:
>
> {{{
> def __hash__(self):
> return hash(self.value)
> }}}
New description:
As
[https://github.com/django/django/blob/b7fb608142a0be568bc5dce952de5e6aefc2488c/django/utils/deprecation.py#L87
CallableBool] has no hash method, membership test operations for sets do
not work:
{{{
from django.utils.deprecation import CallableTrue
assert CallableTrue in {True}
TypeError: unhashable type: 'CallableBool'
}}}
Adding a hash method solves this problem:
{{{
def __hash__(self):
return hash(self.value)
}}}
--
Comment:
It seems a bit odd to have such code, but I suppose it doesn't hurt.
--
Ticket URL: <https://code.djangoproject.com/ticket/27309#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/062.56bb34dfa686ae690de8c1602078e965%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
