#27517: TemplateResponseMixin with charset does not worked
--------------------------------+--------------------------------------
Reporter: Kosei Kitahara | Owner: nobody
Type: Bug | Status: new
Component: Generic views | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+--------------------------------------
Description changed by Kosei Kitahara:
Old description:
> When create class based view which contain `TemplateResponseMixin`,
>
> {{{
> class MyTemplateView(TemplateResponseMixin, ContextMixin, View):
> def get(self, request, *args, **kwargs):
> context = self.get_context_data(**kwargs)
> return self.render_to_response(context,
> charset=kwargs.get('charset', 'utf-8'))
> }}}
>
> `TemplateResponseMixin.render_to_response` call `SimpleTemplateResponse.
> __init__` with a `charset` keyword argument.
> But above method passed charset which is none-keyword argument.
> Also `content_type` and `status` are same too.
New description:
When create a class based view which contain `TemplateResponseMixin`,
{{{
class MyTemplateView(TemplateResponseMixin, ContextMixin, View):
def get(self, request, *args, **kwargs):
context = self.get_context_data(**kwargs)
return self.render_to_response(context,
charset=kwargs.get('charset', 'utf-8'))
}}}
`TemplateResponseMixin.render_to_response` calls `SimpleTemplateResponse.
__init__` with a `charset` keyword argument.
But, the above method passed `charset` as a non-keyword argument.
In addition, `content_type`, `status` are passed also as nonｰkeyword
arguments, which seems in a wrong order.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/27517#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/063.14a0fffbf76e781363984307c18378fa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
