#27731: Squashmigrations doesn't optimize AlterField related_name across
AlterUniqueTogether/AlterIndexTogether
--------------------------------------+------------------------------------
Reporter: Ed Morley | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: squashmigrations | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Andrew Nester):
I guess this behaviour is expected.
We have following assert in OptimizerTest
{{{
self.assertDoesNotOptimize(
[
migrations.CreateModel("Foo", [
("a", models.IntegerField()),
("b", models.IntegerField()),
]),
alter,
migrations.AlterField("Foo", "b",
models.CharField(max_length=255)),
],
)
}}}
In general, if we have {{{ AlterUniqueTogether}}} set for some field,
let's say `a`, and after that performs `AlterField` on same field then we
do not perform optimisation.
Actually it could be fixed, but it requires some thoughts about how to
determine what changes introduce this `AlterFIeld` - some of them could be
safe to optimise, some of them not.
--
Ticket URL: <https://code.djangoproject.com/ticket/27731#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.46f9e3222010292c7f27dcce31174898%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
