#25187: Make request available in authentication backends
-------------------------------------+-------------------------------------
     Reporter:  Carl Meyer           |                    Owner:  Tim
                                     |  Graham <timograham@…>
         Type:  New feature          |                   Status:  closed
    Component:  contrib.auth         |                  Version:  master
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Tim Graham):

 It looks like `CASBackend.authenticate()` doesn't follow
 [https://docs.djangoproject.com/en/stable/topics/auth/customizing
 /#writing-an-authentication-backend the advice in the documentation], "The
 `authenticate` method takes credentials as keyword arguments." Instead,
 it's taking positional arguments.

 I'm not against trying to maintain backwards compatibility for this case
 but I'm not sure that it's a high priority. Are you willing to try to
 write a patch? I'll attach a test that I started.

--
Ticket URL: <https://code.djangoproject.com/ticket/25187#comment:14>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.9f9ea6d12d69b10bfe92a7cfc6fb6e3a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to