#28095: Document Widget.build_attrs() signature change in Django 1.11
-------------------------------------+-------------------------------------
Reporter: Melvyn Sopacua | Owner: brian
Type: | houston morrow
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Melvyn Sopacua):
I don't think it should be documented.
The apparent reason for making this backwards-incompatible change was that
it was deemed internal (''because'' it was not documented).
However - it is widely used in the field, as `Widget.render()` used to be
abstract and widget implementors copied code from `InputWidget` and
friends, which used build_attrs.
But because it is widely used and incompatible, it should be noted in the
release notes.
Personally, I expect this method to be removed, as it's nothing more then
a wrapper for `dict.update()`, with no added value (the fact that you
could pass keyword arguments that would be added as attributes was it's
added value, as that is much easier to type and read).
--
Ticket URL: <https://code.djangoproject.com/ticket/28095#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/072.cbefcdcdbeaadccf092e09ac9f8d97fe%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
