#28496: ChangeList instantiation code buried in ModelAdmin.changelist_view is
not
reusable
-------------------------------------+-------------------------------------
Reporter: Simon | Owner: Simon Meers
Meers |
Type: | Status: assigned
Cleanup/optimization |
Component: | Version: 1.11
contrib.admin |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
As requested/discussed in https://github.com/django/django/pull/8856
It is sometimes necessary to access the filtered/searched QuerySet
generated by the current request parameters outside of the
`changelist_view`. For example, when exporting the current queryset in a
custom view. In the current implementation, this cannot be achieved in a
DRY fashion. Extracting the `ChangeList` instantiation into its own method
allows this DRY reuse.
This also allows the test code to utilise consistent/DRY instantiation of
`ChangeList` objects in place of the current hacks such as
`admin_changelist.tests.get_changelist_args` -- see new pull request.
--
Ticket URL: <https://code.djangoproject.com/ticket/28496>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/050.7e7f9debc1285f725584912ea959e565%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
