#28719: Better exception message when get_queryset returns None
-------------------------------------+-------------------------------------
     Reporter:  Bjorn Kristinsson    |                    Owner:  (none)
         Type:                       |                   Status:  new
  Cleanup/optimization               |
    Component:  Generic views        |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by hpfn):

 * cc: hpfn (added)


Comment:

 Hi,

 I read the patch and ran the tests.

 Ran 202 tests in 3.730s
 OK

 It seems that the patch does what the author wants.  If
 there is no information at all raise 'ImproperlyConfigured'.

 patch ok
 tests ok
 docs ok

 I am not changing to 'Ready for checkin' because this is
 my first time doing a review.



 Regards,
 Herbert

-- 
Ticket URL: <https://code.djangoproject.com/ticket/28719#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.8ca4133eedce34ce5023836833d38ac6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to