#28779: PasswordChangeView and PasswordChangeDoneView do not use a custom
REDIRECT_FIELD_NAME
-------------------------------------+-------------------------------------
Reporter: Meiyer | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.auth | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):
* type: Bug => Cleanup/optimization
* component: Core (URLs) => contrib.auth
Comment:
As far as I see, the problem isn't specific to the password change views.
If you customize `LoginView.redirect_field_name`, then you need to update
all views decorated with `login_required()` to use
`@login_required(redirect_field_name='...')`. The problem is that you
can't make this change in views in third-party apps. For that reason, I
wonder if it would have been better to make `REDIRECT_FIELD_NAME`
customization use a setting (as originally proposed in #5394) rather than
an argument.
--
Ticket URL: <https://code.djangoproject.com/ticket/28779#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.28d668030891f228c54c2e64c7583975%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
