#28823: Nested @override_settings on class and method do not work correctly
-------------------------------+--------------------------------------
     Reporter:  Paolo D'Apice  |                    Owner:  (none)
         Type:  Bug            |                   Status:  new
    Component:  Uncategorized  |                  Version:  1.10
     Severity:  Normal         |               Resolution:
     Keywords:                 |             Triage Stage:  Unreviewed
    Has patch:  0              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+--------------------------------------

Comment (by Piotr DomaƄski):

 Is it really bad behaviour? In test_delete_foo you don't change value of
 MY_DATA but you modify item in previous value of MY_DATA setting.
 Rollback will be performed if you change
 {{{
         del settings.MY_DATA['foo']
 }}}
 into:
 {{{
         settings.MY_DATA = {'bar': 2}
 }}}


 Should all deep copies of all settings values be freezed during entering
 override_settings? What about complex objects?

-- 
Ticket URL: <https://code.djangoproject.com/ticket/28823#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.ed4f752c992d87f8b274928b5d22a33c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to