#28996: Simplify some boolean constructs and remove some trivial 'continue'
statements
--------------------------------------+------------------------------------
Reporter: Дилян Палаузов | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Tim Graham):
Test failure:
{{{
======================================================================
FAIL: test_render_int
(forms_tests.widget_tests.test_checkboxinput.CheckboxInputTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/opt/python3.6.4/lib/python3.6/unittest/case.py", line 59, in
testPartExecutor
yield
File "/opt/python3.6.4/lib/python3.6/unittest/case.py", line 605, in run
testMethod()
File
"/home/tim/code/django/tests/forms_tests/widget_tests/test_checkboxinput.py",
line 40, in test_render_int
html='<input checked type="checkbox" name="is_cool" value="0" />',
File "/home/tim/code/django/tests/forms_tests/widget_tests/base.py",
line 25, in check_html
assertEqual(output.replace('"', '"'), html)
File "/home/tim/code/django/django/test/testcases.py", line 680, in
assertHTMLEqual
self.fail(self._formatMessage(msg, standardMsg))
File "/opt/python3.6.4/lib/python3.6/unittest/case.py", line 670, in
fail
raise self.failureException(msg)
AssertionError: <input name="is_cool" type="checkbox" /> != <input checked
name="is_cool" type="checkbox" value="0" />
- <input name="is_cool" type="checkbox" />
+ <input checked name="is_cool" type="checkbox" value="0" />
? ++++++++ ++++++++++
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28996#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/072.f875e3c1b5e80d94a5aff1ebe7bb1203%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
