#29048: Add **extra_context arg to as_vendor methods in database functions
-------------------------------------+-------------------------------------
Reporter: Matthew Pava | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Old description:
> `Func` inherits from `SQLiteNumericMixin`, which added an extra argument
> to `as_sqlite`: `**extra_context`. Based on feedback from other
> developers, it seems we should add this argument to each `as_vendor`
> method.
New description:
`Func` inherits from `SQLiteNumericMixin`, which added an extra argument
to `as_sqlite`: `**extra_context`. PyCharm flags the database functions
that inherit from `Func` because their `as_sqlite` methods do not have
that extra argument.
--
Comment (by Matthew Pava):
I updated the description to describe the problem in better detail.
When I was working on
[https://github.com/django/django/pull/9583/files/4b61d2bc73641edbe303ecdbcc8f810db795f1b3
#diff-bda8c5979f2cb4b5bf2d3f87f507363f PR 9583], a contributor made this
comment when I had unintentionally made the changes to other classes not
related to that PR:
> I've also noticed a warning in Pycharm that the signature of as_sqlite
and as_oracle doesn't match the superclass. I'd guess it's better to deal
with this in a different PR.
I assumed that the contributor was speaking on behalf of "other
developers."
--
Ticket URL: <https://code.djangoproject.com/ticket/29048#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.aaf7c91113c2f317568afaef8f848e9b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
