#28198: Model attributes shouldn't override deferred fields
-------------------------------------+-------------------------------------
Reporter: Ryan Hiebert | Owner:
| Denis.Tarykin
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):
* needs_better_patch: 0 => 1
Comment:
Feedback on patch:
* At the least, please break out the logic adjusting attributes on parent
models and add tests for those.
* Can we not do this without actually altering the parent models? (e.g.
one possibility, by noting duplicates and checking against that in
`Field.contribute_to_class`)
* This should be helped by extracting the helper methods but, it wasn't
clear what the code was doing and why. The comments should be clarified if
necessary.
Please uncheck "Patch needs improvement" after updating.
--
Ticket URL: <https://code.djangoproject.com/ticket/28198#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/069.56b0d6898de21fa23387d0b87d69cf4f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
