#29069: Static file serving does not call request_finished signal
-------------------------------------+-------------------------------------
Reporter: André Cruz | Owner: nobody
Type: Bug | Status: new
Component: HTTP handling | Version: 1.11
Severity: Normal | Resolution:
Keywords: streamingresponse | Triage Stage: Accepted
request_finished |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tom Forbes):
I started to see if this was possible to fix, and I think it's pretty
easy: We just need to set the `wsgi_file_wrapper` attribute to be the
`FileResponse` class. It's compatible with the wsgiref default one.
Possible PR: https://github.com/django/django/pull/9659
It seems suspiciously easy to fix, there could be some unforeseen
consequences here. If Django has never sent a request_finished signal for
static files, do we want to now? We could just document it, I mean in
production these signals would not be sent anyway.
--
Ticket URL: <https://code.djangoproject.com/ticket/29069#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.55ae646975130d18615d2ab7b2e86378%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
