#29098: Allow assertRedirects to handle regex matches.
-------------------------------------+-------------------------------------
     Reporter:  Dan J Strohl         |                    Owner:  nobody
         Type:                       |                   Status:  new
  Cleanup/optimization               |
    Component:  Testing framework    |                  Version:  1.11
     Severity:  Normal               |               Resolution:
     Keywords:  unittest redirect    |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Dan J Strohl):

 Replying to [comment:1 Tim Graham]:
 > I'm not really in favor of the additional complexity. In the admin
 tests, for example, the problem is solved like this:
 > {{{
 > response = <post request to create new object>
 > new_user = User.objects.get(username='newuser')
 > self.assertRedirects(response, reverse('admin:auth_user_change',
 args=(new_user.pk,)))
 > }}}
 > Does that work for you?

 I understand and am generally in agreement with keeping things simple...

 While your suggestion would generally work (I think at least, I haven't
 tried it), it feels like it would be easier (from the developers pov) to
 be able to test if a redirect matched a url pattern, or one of the new url
 matching.. (objects?),  in addition to simply matching a string.  that way
 a developer could be as specific (or fuzzy) as they wished.  and it would
 directly link back to checking the url patterns as well.

 The ability to pull out the string is nice, but not really crucial to the
 specific feature request.

 I would not put this as a critical feature request, but perhaps a bit more
 than a "nice to have".

-- 
Ticket URL: <https://code.djangoproject.com/ticket/29098#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.c1caebb2e13a158d3a7249e5e6d398bf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to