#27398: Make SimpleTestCase.assertRedirects() URL comparison ignore ordering of
query parameters
-------------------------------------+-------------------------------------
Reporter: Cédric Codet | Owner: Jan
Type: | Pieter Waagmeester
Cleanup/optimization | Status: assigned
Component: Testing framework | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Jan Pieter Waagmeester):
I just pushed a commit splitting of `assertURLRedirects()`, and included
some extra tests.
I tried using `QueryDict`, but they preserve their creation order when
`.urlencode()` is called and thus do not allow re-creating the url. I like
to do that because it simplifies the output, but if you still think the
way it was done in the implementation I removed, I'll update my
implementation to look more like that one.
Do we need to add tests checking the message produced if the assertion
fails?
--
Ticket URL: <https://code.djangoproject.com/ticket/27398#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.c78da98e9b19e38c1373e8dae22904b0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
