#28712: Add ability to apply separate attributes to ChoiceWidget options
     Reporter:  Stephen Swatman      |                    Owner:  Stephen
                                     |  Swatman
         Type:  New feature          |                   Status:  assigned
    Component:  Forms                |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:  ChoiceWidget         |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
Changes (by Carlton Gibson):

 * needs_better_patch:  0 => 1


 I've left a review on the patch.

 My main concern is the documentation: we need to properly document
 `ChoiceWidget` so that this new feature would make sense.

 Beyond that (also on the PR) I think we should be advocating the subclass
 and override `create_option` approach. I know people always want an extra
 keyword arg, but such an approach is both lightweight and maintainable
 (both for Django and user code).

 That approach is under-documented currently. I would advocate closing this
 as `wontfix` and creating a new ticket to properly document

Ticket URL: <https://code.djangoproject.com/ticket/28712#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
For more options, visit https://groups.google.com/d/optout.

Reply via email to