#5445: Checking iterables by looking for a __iter__ attribute doesn't work on
Jython
--------------------------------------------+-------------------------------
Reporter: leosoto <[EMAIL PROTECTED]> | Owner: nobody
Status: new | Component: Core
framework
Version: SVN | Resolution:
Keywords: jython | Stage: Accepted
Has_patch: 1 | Needs_docs: 0
Needs_tests: 0 | Needs_better_patch: 0
--------------------------------------------+-------------------------------
Changes (by mtredinnick):
* stage: Ready for checkin => Accepted
Comment:
I'm not in love with the implementation. A couple of comments:
* you create _is_iterable in validation.py and then later on do almost
the exact same thing in test/client.py. Why not create a file in
django/utils/ called something appropriate (or use itercompat.py, which we
already have) and put a utility function in there?
* Does Jython have a basestring type? We use isinstance(foo, basestring)
all over the place in Django, so it'd be nice we could also use that here
instead of types.StringType. Otherwise there are a lot of places you're
going to have to change.
--
Ticket URL: <http://code.djangoproject.com/ticket/5445#comment:2>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
