#29447: RelatedManager.set() doesn't pass bulk keyword argument to clear()
-------------------------------------+-------------------------------------
Reporter: Jeremy Lainé | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: 2.0
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by Jeremy Lainé:
Old description:
> For reverse many-to-one relations, the `set` method's `bulk` keyword
> argument is passed down to the `add()` and `remove()` methods. It isn't
> however passed down to the `clear()` method:
>
> https://github.com/django/django/blob/265506bbc347a6b3fcc6c66ab1a2417b3b7ea57a/django/db/models/fields/related_descriptors.py#L711
>
> This looks like a bug, as passing bulk=True, clear=True results in the
> following behavior:
>
> - clear() is invoked in "non-bulk" mode, triggering signals
> - add() is correctly invoked in "bulk" mode, no signals are not triggered
>
> I spotted this while reading the `related_descriptors.py` code to fix
> #29440.
New description:
For reverse many-to-one relations, the `set` method's `bulk` keyword
argument is passed down to the `add()` and `remove()` methods. It isn't
however passed down to the `clear()` method:
https://github.com/django/django/blob/265506bbc347a6b3fcc6c66ab1a2417b3b7ea57a/django/db/models/fields/related_descriptors.py#L711
This looks like a bug, as passing bulk=False, clear=True results in the
following behavior:
- clear() is invoked in "bulk" mode, not triggering signals
- add() is invoked in "non-bulk" mode, signals are triggered
Admitedly, I'm not too sure why you would want to do this, but at the very
least the docs should mention if this combination is unsupported.
I spotted this while reading the `related_descriptors.py` code to fix
#29440.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/29447#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.d3ca7950f9bc8c65050cf30ebd1cfee4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
