#29419: Limiting visibility of Admin actions to `change` permission only isn't
right.
-------------------------------------+-------------------------------------
     Reporter:  Paulo                |                    Owner:  Hiroki
                                     |  Kiyohara
         Type:  Bug                  |                   Status:  assigned
    Component:  Documentation        |                  Version:  2.1
     Severity:  Release blocker      |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Carlton Gibson):

 [https://github.com/django/django/pull/10024 New PR] partially reverting
 825f0beda804e48e9197fcf3b0d909f9f548aa47 to restore visibility of actions
 to all staff users.

 * Individual actions should check permissions.
 * Additionally, users may follow the steps in
 [https://docs.djangoproject.com/en/dev/ref/contrib/admin/actions
 /#conditionally-enabling-or-disabling-actions Conditionally enabling or
 disabling actions].

 _Maybe_ we could add an `allowed_permissions` tuple to the action
 functions — so `delete_selected` would have `(delete,)` — that could be
 examined in the default implementation of `get_actions()`. (but that seems
 like a New Feature beyond the scope of this one...)

-- 
Ticket URL: <https://code.djangoproject.com/ticket/29419#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.e5d234f881cca77ce5bd656801bef0e0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to