#29508: Simplify overriding `login_form` in AdminSite
------------------------------------------------+------------------------
Reporter: remilapeyre | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 2.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
When setting `login_form` of `AdminSite` to a subclass of
AdminAuthenticationForm an AppRegistryNotReady exception gets raised as
documented in
https://github.com/django/django/blob/master/django/contrib/admin/sites.py#L377.
This problem makes it harder to customize the administration site as it
requires to override the whole `login` method of AdminSite to bypass it.
The attached patch use `import_string` to let users specify the class to
use as a string and import it at runtime.
--
Ticket URL: <https://code.djangoproject.com/ticket/29508>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/054.52882fe1dbb4e36118fdb66fa67aa039%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
