#26001: Make ModelAdmin.search_fields do an integer lookup for IntegerFields
--------------------------------------+------------------------------------
Reporter: Tim Graham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham):
* needs_better_patch: 1 => 0
* has_patch: 1 => 0
Comment:
As far as I tested, you can now use something like `search_fields =
['votes__exact']` to do the appropriate query, however, if a non-integer
search term is entered, the page crashes with `ValueError invalid literal
for int() with base 10: 'abc'` from `IntegerField.get_prep_value()`.
Probably that exception should be caught in
`ModelAdmin.get_search_results()` and no results returned.
--
Ticket URL: <https://code.djangoproject.com/ticket/26001#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.882e10079407dfc26b962f5afff83e60%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
