#29599: chunk_size for InMemoryUploadedFile is not used
-------------------------------------+-------------------------------------
     Reporter:  Ali Aliyev           |                    Owner:  nobody
         Type:                       |                   Status:  closed
  Cleanup/optimization               |
    Component:  File                 |                  Version:  master
  uploads/storage                    |
     Severity:  Normal               |               Resolution:  invalid
     Keywords:  chunks               |             Triage Stage:
                                     |  Unreviewed
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 > is it okay...

 Yes.

 In general, why do you handle a file in chunks? So that you can control
 how much is in memory at one time.

 With `InMemoryUploadedFile` you already decided you'd handle the whole
 thing in memory at once.
 So the idea of handling it in `chunks` doesn't really make sense.

 (See
 
[https://github.com/django/django/blob/1c05fe65f280cedaddf5e5f308e5e45449b02e93/django/core/files/uploadedfile.py#L95
 the comment a few lines below].)

-- 
Ticket URL: <https://code.djangoproject.com/ticket/29599#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.003ad1fa6e0a715c37415a3b4d942952%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to