#29603: dumpdata management command database router usage
-------------------------------------+-------------------------------------
               Reporter:  Tommaso    |          Owner:  nobody
  Barbugli                           |
                   Type:             |         Status:  new
  Uncategorized                      |
              Component:  Core       |        Version:  2.0
  (Management commands)              |
               Severity:  Normal     |       Keywords:
           Triage Stage:             |      Has patch:  0
  Unreviewed                         |
    Needs documentation:  0          |    Needs tests:  0
Patch needs improvement:  0          |  Easy pickings:  0
                  UI/UX:  0          |
-------------------------------------+-------------------------------------
 The dumpdata management command uses router.allow_migrate_model to
 determine whether the dump should be done or not (in dumpdata's
 Command.get_objects method). This is clearly not the right thing to do
 since that function is used to determined whether a migration should be
 performed or not.

 Note: this check is performed even if the command has a database
 specified.

 Ideally we'd extend router's interface to have an 'allow_dump_data' method
 rather than use an existing method that serves a different purpose.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/29603>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.520e8254c21ae36676ce482c7b45a3a9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to