#30028: Uneditable object still editable through change_list if list_editable 
not
empty
-------------------------------+--------------------------------------
     Reporter:  ksl            |                    Owner:  nobody
         Type:  Bug            |                   Status:  closed
    Component:  contrib.admin  |                  Version:  2.1
     Severity:  Normal         |               Resolution:  worksforme
     Keywords:  changelist     |             Triage Stage:  Unreviewed
    Has patch:  0              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+--------------------------------------

Comment (by Carlton Gibson):

 Happy to look at a project if you can provide one but just glancing at the
 code, it looks like a programming error: you’re going to need to look at
 the `request.user` to see what you should return. Otherwise you’ve
 overridden the default implementation, which protects against this sort of
 thing.

 You should probably be calling `super()` before your own logic, and only
 continuing if that returns `True`.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/30028#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.cdf45ce50fa2d23c0ea20cec8273205a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to