#26840: Extract database teardown from DiscoverRunner, to better support third-
party test runners
--------------------------------------+------------------------------------
     Reporter:  Carl Meyer            |                    Owner:  nobody
         Type:  Cleanup/optimization  |                   Status:  closed
    Component:  Testing framework     |                  Version:  1.9
     Severity:  Normal                |               Resolution:  fixed
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  1                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------

Comment (by Tim Graham <timograham@…>):

 In [changeset:"f6d8b0c47e5027037ed8c9926b1cc67d328091e6" f6d8b0c4]:
 {{{
 #!CommitTicketReference repository=""
 revision="f6d8b0c47e5027037ed8c9926b1cc67d328091e6"
 Refs #26840 -- Corrected SQLite connection mocking in a setup_databases()
 test.

 The test was expecting connections used by
 DiscoverRunner.setup_databases()
 to be the ones defined in django.test.runner but this doesn't hold true
 since this method was made a proxy of django.test.utils.setup_databases.

 This broke the TransactionTestCase.serialized_rollback feature in the test
 suite because calls to create_db_test() cleared the test data persisted on
 connections objects.

 Added an assertions to prevent this from happening again.
 }}}

-- 
Ticket URL: <https://code.djangoproject.com/ticket/26840#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.8413b0e6239ec63cdc010437504b145b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to