#30268: Django admin list_editable overrides changes done elsewhere
-------------------------------------+-------------------------------------
     Reporter:  Brillgen Developers  |                    Owner:  nobody
         Type:                       |                   Status:  closed
  Cleanup/optimization               |
    Component:  contrib.admin        |                  Version:  2.1
     Severity:  Normal               |               Resolution:  invalid
     Keywords:  admin                |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 Hi. This looks invalid.

 When processing the `list_editable` submission,
 
[https://github.com/django/django/blob/413d50b5ff0c0a4198d4bf069e6434bc7ba4cd86/django/contrib/admin/options.py#L1728-L1731
 each form is only saved if there are edits]:

 {{{
             if formset.is_valid():
                 changecount = 0
                 for form in formset.forms:
                     if form.has_changed():
                           #... obj is updated...
 }}}

 That looks like the behaviour you're suggesting.

 If I've misunderstood, please provide a minimal test case or project
 showing the incorrect behaviour and we can have a look.

 Thanks.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/30268#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4b935986ac8f5d26f04168b5b6667574%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to