#23004: Cleanse entries from request.META in debug views
---------------------------------+-----------------------------------------
Reporter: Daniel Hahler | Owner: Daniel Maxson
Type: New feature | Status: assigned
Component: Error reporting | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+-----------------------------------------
Comment (by Daniel Maxson):
Thanks for the clarification. I misunderstood your previous comment. I
think what you're saying gets to the point I mention in the PR here:
{{{
I added the values as optional construction arguments with the defaults
coming from constants defined on the class. The class definition looks a
little clunkier but my thinking was this may be more pleasant to use when
actually creating subclasses than needing to update the attributes only
after construction.
Still, I'm not married to this approach and can remove the arguments (and
make any other changes) if the approach in the new commits doesn't sit
right with people.
}}}
My PR was intended primarily as an effort to bring Ryan's PR up to date
just because there hadn't been work on it in a while and I wanted to get
this feature for my own use. I happened to throw in the arguments while
working on that because it felt strange to me at the time not to, but
having done that, I can see the case against the added complexity.
Regardless, adding the arguments is outside the scope of this ticket so in
retrospect I should have limited myself only to updating Ryan's PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/23004#comment:23>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/065.90221dd1989746239328a84ab20434d5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
