#5047: max-age set by cache_page is overwritten by cache_middleware
--------------------------------------------------------------+-------------
Reporter: permon |
Owner: permon
Status: assigned |
Component: Cache system
Version: SVN |
Resolution:
Keywords: cache_control, cache, middleware, sprintsept14 |
Stage: Accepted
Has_patch: 1 |
Needs_docs: 0
Needs_tests: 0 |
Needs_better_patch: 0
--------------------------------------------------------------+-------------
Comment (by permon):
Replying to [comment:7 jacob]:
> I'm not sure this "rewrite" argument is needed -- shouldn't
patch_cache_control() simply respect an existing max-age argument and not
overrite it? Or perhaps set it to max(old, new)?
Yes, I look at the patch and it was really ineffective :-( So my change is
to use minimum of these two values. It makes me more sense than maximum of
them. I think that nearest cache invalidation time should be the effective
one.
--
Ticket URL: <http://code.djangoproject.com/ticket/5047#comment:8>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
