#30523: StatReloader does not update file times if notify_file_changed() is
     Reporter:  Tom Forbes       |                    Owner:  Tom Forbes
         Type:  Bug              |                   Status:  closed
    Component:  Utilities        |                  Version:  2.2
     Severity:  Release blocker  |               Resolution:  fixed
     Keywords:                   |             Triage Stage:  Accepted
    Has patch:  1                |      Needs documentation:  0
  Needs tests:  0                |  Patch needs improvement:  0
Easy pickings:  0                |                    UI/UX:  0

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

 In [changeset:"7089502b98f80e8dc1c8f6e85fb0620809aec30e" 7089502b]:
 #!CommitTicketReference repository=""
 [2.2.x] Fixed #30523 -- Fixed updating file modification times on seen
 files in auto-reloader when using StatReloader.

 Previously we updated the file mtimes if the file has not been seen
 before - i.e on the first iteration of the loop.

 If the mtime has been changed we triggered the notify_file_changed()
 method which in all cases except the translations will result in the
 process being terminated. To be strictly correct we need to update the
 mtime for either branch of the conditional.

 Regression in 6754bffa2b2df15a741008aa611c1bb0e8dff22b.

 Backport of 480492fe70b0bb7df61c00854dc8535c9d21ba64 from master

Ticket URL: <https://code.djangoproject.com/ticket/30523#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
For more options, visit https://groups.google.com/d/optout.

Reply via email to