#30551: urlize on URL with incomplete query string adds equal sign.
-------------------------------+--------------------------------------
     Reporter:  jochengcd      |                    Owner:  nobody
         Type:  Uncategorized  |                   Status:  new
    Component:  Utilities      |                  Version:  master
     Severity:  Normal         |               Resolution:
     Keywords:                 |             Triage Stage:  Unreviewed
    Has patch:  0              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+--------------------------------------
Changes (by felixxm):

 * version:  1.11 => master
 * component:  Uncategorized => Utilities


Comment:

 Thanks for the report.
 
[https://github.com/django/django/blob/c498f088c584ec3aff97409fdc11b39b28240de9/django/utils/html.py#L220-L223
 smart_urlquote()] adds a trailing equal sign. I noticed that `parse_qsl()`
 raises:
 {{{
   File "/usr/lib/python3.6/urllib/parse.py", line 693, in parse_qsl
     raise ValueError("bad query field: %r" % (name_value,))
 ValueError: bad query field: '284309'
 }}}
 when we add `strict_parsing=True` flag, hence I believe that query string
 used by this site is incorrect. I'm not sure that we should handle this
 case in Django.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/30551#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.47c13844734e4d3ec11d16819a63d90b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to