#30620: A full example in documentation is not PEP8 compliant.
--------------------------------------+------------------------------------
     Reporter:  Nuno                  |                    Owner:  nobody
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  Documentation         |                  Version:  master
     Severity:  Normal                |               Resolution:
     Keywords:  documentation PEP8    |             Triage Stage:  Accepted
    Has patch:  0                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  1                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by felixxm):

 * version:  2.2 => master
 * stage:  Unreviewed => Accepted


Comment:

 Thanks for this report. Normally we don't restrict all PEP8 rules in
 examples, e.g. in most of cases we don't put 2 blank lines before class
 definition. In this case we have a full example that can be copy & paste,
 so we can make it PEP8 compliant, for that please fix also
 `add_fieldsets`:
 {{{
 diff --git a/docs/topics/auth/customizing.txt
 b/docs/topics/auth/customizing.txt
 index daec10c28e..7d287051d8 100644
 --- a/docs/topics/auth/customizing.txt
 +++ b/docs/topics/auth/customizing.txt
 @@ -1162,13 +1162,14 @@ code would be required in the app's ``admin.py``
 file::
          add_fieldsets = (
              (None, {
                  'classes': ('wide',),
 -                'fields': ('email', 'date_of_birth', 'password1',
 'password2')}
 -            ),
 +                'fields': ('email', 'date_of_birth', 'password1',
 'password2'),
 +            }),
          )
          search_fields = ('email',)
          ordering = ('email',)
          filter_horizontal = ()
 }}}

-- 
Ticket URL: <https://code.djangoproject.com/ticket/30620#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.31adedc1e3275e4030a6f7cf729530d2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to