#30625: DatabaseCache backend raises TypeError if get/delete received key as
integer.
---------------------------------+------------------------------------
     Reporter:  Hiroki Kiyohara  |                    Owner:  nobody
         Type:  Bug              |                   Status:  new
    Component:  Documentation    |                  Version:  2.2
     Severity:  Normal           |               Resolution:
     Keywords:                   |             Triage Stage:  Accepted
    Has patch:  0                |      Needs documentation:  0
  Needs tests:  0                |  Patch needs improvement:  0
Easy pickings:  0                |                    UI/UX:  0
---------------------------------+------------------------------------
Changes (by Carlton Gibson):

 * cc: Nick Pope (added)
 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


Comment:

 OK, thanks for the report Hiroki.

 I'm going to accept this as a documentation issue as you suggest.

 **But** I'm not 100% sure that having `validate_key()` called before
 `make_key()` in abd0ad7681422d7c40a5ed12cc3c9ffca6b88422 is an intended
 behaviour.
 (Elsewhere in `django.core.cache.backends` `make_key()` is called first.)

 As such I'm just CC-ing Nick Pope, who was one of the reviewers on the
 change there for a second opinion. (Do we want to
 [https://github.com/django/django/pull/10257/files#diff-
 15ffac8104265856ed58abb2040945c2R59 have a temporary variable to allow
 `make_key()` then `validate_key()` in this loop] Nick? Thanks!)

-- 
Ticket URL: <https://code.djangoproject.com/ticket/30625#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4d5d18959ec3f09a218b3c595f27035d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to