#30689: Fix documentation for the `fields` argument of MultiValueField
-------------------------------+--------------------------------------
     Reporter:  Adam Sołtysik  |                    Owner:  nobody
         Type:  Bug            |                   Status:  closed
    Component:  Documentation  |                  Version:  master
     Severity:  Normal         |               Resolution:  invalid
     Keywords:                 |             Triage Stage:  Unreviewed
    Has patch:  0              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+--------------------------------------

Comment (by Adam Sołtysik):

 My problem was that the `fields` argument was not passed to the
 constructor of a class inheriting from `MultiValueField`. In Django 1.11
 it worked, because empty tuple `()` was the default for this argument,
 just like in the class header in the documentation, and since Django 2.0
 there is no default value. The exact code change is here:
 
https://github.com/django/django/commit/8e752d84378c7169ef73a483ffffcba55a08c867.

 I think this is a breaking change that should be documented in the release
 notes. This:

 {{{Form fields no longer accept optional arguments as positional
 arguments}}}

 is not relevant, since `fields` is in fact accepted as a positional
 argument.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/30689#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.fe7e8035e8d40877beb73b0f5096abd8%40djangoproject.com.

Reply via email to